Repository navigation
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
|
Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
Fixes: #21834
Problem with
nameMoveOverlapon,nameGapwas applied before the overlap move. So smallnameGapvalues all gave the same position, and the name only moved when the gap was bigger than the labels. You couldn't set a fixed gap from the labels.What I did in
AxisBuilder.ts, whennameMoveOverlapis on, the name now starts with no gap. After the overlap move is done, I addnameGapin the same direction. SonameGap: 10always means 10px past the labels. NegativenameGapis ignored in this mode so the name doesn't go back on the labels. WithnameMoveOverlapoff, nothing changes. I also updated thenameGapandnameMoveOverlapcomments inaxisCommonTypes.tsto match.