FINERACT-2784: Migrate NotesTest integration tests to Feign - #6328
Open
DhroovSankla wants to merge 1 commit into
Open
FINERACT-2784: Migrate NotesTest integration tests to Feign#6328DhroovSankla wants to merge 1 commit into
DhroovSankla wants to merge 1 commit into
Conversation
Contributor
Author
|
@adamsaghy |
Signed-off-by: Dhroov Sankla <dhroovsankla2004@gmail.com>
DhroovSankla
force-pushed
the
FINERACT-2784-migrate-notestest-to-feign
branch
from
August 27, 2026 08:24
18edfd4 to
895ab9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request resolves FINERACT-2784 by migrating
NotesTest.javato use Fineract's generated type-safe Feign client APIs instead of legacy RestAssured calls.NotesTest.javatoorg.apache.fineract.integrationtests.clientpackage.IntegrationTestclass.NotesHelpercalls with calls tofineractClient().notes.NoteCreateRequestandNoteUpdateRequestmodel builders.Calls.executeUto check for404status codes.Impact
Verifications
./gradlew spotlessApplycompleted successfully../gradlew :integration-tests:checkstyleTestpassed without any violations../gradlew :integration-tests:test --tests "org.apache.fineract.integrationtests.client.NotesTest"successfully passed all 13 test cases.