Conversation
Use a child-local identity mapping when adapting nested ROW values. Add six adapter regressions and a pipeline write/read regression for reordered columns. Generated-by: Codex CLI 0.154.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fix incorrect nested ROW values in the Fluss pipeline sink when the parent column mapping reorders columns or does not cover every child position. For example, mapping
[nested, id]to[id, nested]must preserve(7, 8)inside the nested row. See FLINK-40690.Brief change log
Row.of(42, Row.of(7, 8))without aLIMIT.Verifying this change
Row.of(42, Row.of(8, 7)).CdcAsFlussRowTestcases, 19FlussConversionsTestcases, twoFlussEventSerializationSchemaTestcases, and the newFlussSinkPipelineITCase#testNestedRowWithReorderedColumns. No failures, errors, or skips.git diff --checkpassed.20260901.094454SNAPSHOT artifacts, avoiding incompatible locally built SNAPSHOT jars. No project dependency or POM changes were required.Documentation
Was generative AI tooling used to co-author this PR?