Repository navigation
Conversation
VasShabu
force-pushed
the
disableOnTimeArgument
branch
from
November 17, 2026 17:22
b7f6c10 to
64e1f07
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Every PTF implicitly gets the optional system arguments
on_timeanduid. A built-in PTF without event-time semantics could only dropon_timethroughdisableSystemArguments(true), which also dropsuid, or by adding its own check. This adds a framework-level switch that rejectson_timeand keepsuid. It is needed byDEDUPLICATE(#29967) and by any other built-in PTF without event time.The switch is only available on
BuiltInFunctionDefinition, so no public API is added.Brief change log
BuiltInFunctionDefinition.Builder#disableOnTimeArgument(boolean)andisOnTimeArgumentDisabled().SystemTypeInference#of(FunctionDefinition, TypeInference)reads the switch from a built-in definition.SystemInputStrategyrejects a non-emptyon_timewith aValidationException. The switch has no effect ifdisableSystemArguments(true)is set.BridgingSqlFunction(SQL) andResolveCallByArgumentsRule(Table API) pass the function definition instead of its kind.No built-in function uses the switch yet.
Verifying this change
This change added tests and can be verified as follows:
SystemTypeInferenceTest:on_time => DESCRIPTOR(ts)is rejected when the switch is on;uidand an emptyon_timeare accepted when it is on;on_timeis accepted when it is off.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Sonnet 5.5)