Conversation
A failure mid-chain skipped later close() calls and leaked off-heap Arrow memory. Close every allocator with IOUtils.closeAll(), and release polled batches if sendFetches() throws after poll. Fixes apache#4345 Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
Author
|
Follow-up from a review of this change: |
Close the unshaded allocator under its lock, and only drop references after a successful close so a later close() can still release leftover native memory. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close()fails, so off-heap memory is not leaked.sendFetches()throws afterpollRecordBatch().Test Plan
mvn test -Dtest=LogRecordReadContextTest -pl fluss-common -ammvn test -Dtest=LogFetcherTest,LogScannerImplTest -pl fluss-client -am🤖 AI-assisted changes - reviewed by human developer
Made with Cursor