HBASE-30248 Validate snapshot region timeout#8468
Open
Sigma-Ma wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/HBASE-30248
What changes were proposed in this pull request?
This change validates
hbase.snapshot.region.timeoutinRegionServerSnapshotManager.When the configured value is less than or equal to zero, HBase logs a warning and falls back to the documented default value of 300000 milliseconds.
All RegionServer snapshot call sites now use the same validated timeout value. The configuration documentation is also updated to state that the value must be greater than zero.
Why are the changes needed?
HBASE-30248 reports that a negative
hbase.snapshot.region.timeoutis passed toThreadPoolExecutoras the keep-alive time during snapshot procedure initialization.This causes an
IllegalArgumentExceptionand aborts the RegionServer during startup. A zero value is also invalid when core thread timeout is enabled.Falling back to the documented default prevents an invalid timeout configuration from aborting the RegionServer.
How was this patch tested?
Added
TestRegionServerSnapshotManager, covering:The focused unit test can be run with:
mvn -pl hbase-server -am -DskipITs -Dtest=TestRegionServerSnapshotManager test