HBASE-30337 Miscellaneous improvements on rpc checks - #8560
Open
Apache9 wants to merge 1 commit into
Open
Conversation
Contributor
|
The changes look good, but github workflows have failures. Is it yetus related issue? |
mnpoonia
approved these changes
Aug 24, 2026
Contributor
There was a problem hiding this comment.
This has really hardened the auth of RPC
very small nit
Adding throws IOException is binary-compatible but source-incompatible for coprocessor callers that invoke these hooks or MasterObserver.super.
Maybe a follow up in phoenix( 😄 @virajjasani ) to handle it, ofcourse which is out of scope of this PR
Contributor
Author
|
Add IOException in method signature usually does not affect CP users, as you are free to not adding the throws signature in your implementation. But yes, this is a incompatible change, will add to the release note. Thanks for reviewing! @mnpoonia |
virajjasani
approved these changes
Aug 26, 2026
liuxiaocs7
reviewed
Aug 26, 2026
| * @param family the table column family, null if don't get table family permission | ||
| * @param qualifier the table column qualifier, null if don't get table qualifier permission | ||
| * @throws IOException if something went wrong | ||
| * @deprecated Since 2.5.17,2.6.8, 2.7.0, 3.0.1 and 3.10, will be removed in 4.0.0. Use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.