HBASE-30165 Preserve sibling replicas in location cache - #8570
Open
1fanwang wants to merge 1 commit into
Open
Conversation
Single-location cache updates used the full metadata merge path, which replaced or truncated sibling replicas. Keep those updates on a separate path while preserving authoritative full-list replacement. Signed-off-by: 1fanwang <1fannnw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The async client can update region replica locations one at a time after a move. Before this change, caching replicas 0, 1, and 2 separately left only one replica in the cache, so later lookups for the sibling replicas missed.
Single-location updates now use a synchronized path that replaces only the matching replica. Different primary regions still use the existing replacement path, and complete metadata responses still control the replica-list length.
Jira: https://issues.apache.org/jira/browse/HBASE-30165
Verification
The regression exercises
AsyncNonMetaRegionLocator.addLocationToCachein ascending and descending replica order. It also checks that a different primary region with the same start key replaces stale siblings.Commands and raw output
Before, on
d11cafefbcbe8b356aaede41fcf9b153dbf2c2bcwith only the regression test applied:After:
The only full-module failure is also present on unmodified master: