HBASE-30339 MobFileCleanupUtil loads store files from the wrong regio… - #8571
Merged
Merged
Conversation
…n directory (apache#8564) Signed-off by: Peng Lu <lupeng@apache.org> (cherry picked from commit d11cafe)
liuxiaocs7
added
the
backport
There was a problem hiding this comment.
Pull request overview
Fixes HBASE-30339 by ensuring MobFileCleanupUtil loads store files using the correct region’s filesystem context, preventing the MOB cleaner from scanning the wrong region directory and incorrectly archiving MOB files (especially when old store files exist).
Changes:
- Load each region’s
RegionInfofrom the on-disk.regioninfoin the actual region directory before creatingHRegionFileSystem. - Add a regression test that reproduces the failure mode with an “old” store file (no
MOB_FILE_REFS) and an old-style MOB file name (no region suffix), ensuring the MOB file is not archived.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanupUtil.java | Create HRegionFileSystem per-region using loadRegionInfoFileContent, ensuring store files are loaded from the correct region directory. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobFileCleanupUtilWithOldStoreFile.java | Adds coverage for the old-store-file scenario to prevent accidental MOB file archival due to incorrect region directory scanning. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n directory (#8564)
Signed-off by: Peng Lu lupeng@apache.org
(cherry picked from commit d11cafe)