HBASE-30094 Reset TestRollbackSCP state before reruns - #8574
Open
Sigma-Ma wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/HBASE-30094
What changes were proposed in this pull request?
Reset the static fault-injection guard and the procedure executor's rollback kill/toggle flags in
TestRollbackSCP#setUpbefore every test attempt.Why are the changes needed?
Surefire reruns failed test methods in the same JVM without invoking
@BeforeAllagain. State left by the first attempt can therefore prevent fault injection on the retry and cause the test to time out while waiting for the procedure executor to stop.Resetting both states in
@BeforeEachmakes every attempt independent.How was this patch tested?
mvn -pl hbase-server -am -PrunLargeTests \ -Dtest=TestRollbackSCP \ -Dsurefire.rerunFailingTestsCount=2 \ -Dwarbucks.skip=true \ clean test