HBASE-30329 Add topology-backed cache diagnostics - #8575
Open
VladRodionov wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the topology-backed cache access framework so that cache diagnostics and cache
access are consistently routed through
TopologyBackedCacheAccessService.The main change is that plain single-tier
BlockCacheimplementations now use the sametopology-backed access path as combined caches. Single-tier caches are represented by
SingleTierTopology, while existing two-tier cache variants continue to use topology-specificrepresentations:
BlockCache->SingleTierTopologyCombinedBlockCache->TieredExclusiveTopologyInclusiveCombinedBlockCache->TieredInclusiveTopologyThis keeps the legacy cache implementations underneath through
BlockCacheBackedCacheEngine, butmoves the access-service boundary to the topology/cache-engine model.
Motivation
After HBASE-30305, exclusive combined-cache orchestration was moved behind
TopologyBackedCacheAccessService. Follow-up testing showed that diagnostic and compatibility pathsstill had assumptions about
BlockCacheBackedCacheAccessServiceand concreteBlockCacheimplementations.
This PR removes those assumptions from the main factory path by making topology-backed access the
normal path for both single-tier and combined caches.
Changes
SingleTierTopology.CacheTopologyType.SINGLE_TIER.BlockCacheinstances.InclusiveCombinedBlockCache.cacheBlock(key, block)behavior for single-tier caches.BlockCacheinstances from topology-backed serviceswhere tests still need direct compatibility checks.
Compatibility notes
BlockCacheBackedCacheAccessServiceis no longer the default factory result for plain block caches.Instead, the main factory now returns a
TopologyBackedCacheAccessServicebacked bySingleTierTopology.The underlying legacy
BlockCacheimplementations are still preserved throughBlockCacheBackedCacheEngine. This PR does not migrateLruBlockCache,BucketCache, or otherconcrete cache implementations to native
CacheEngineimplementations yet. That remains a follow-upmigration step.
Testing
Focused tests: