HBASE-30287 Filter offline and split regions from SnapshotRegionLocator - #8576
Open
Sigma-Ma wants to merge 1 commit into
Open
HBASE-30287 Filter offline and split regions from SnapshotRegionLocator#8576Sigma-Ma wants to merge 1 commit into
Sigma-Ma wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/HBASE-30287
What changes were proposed in this pull request?
Filter offline and split entries while building
SnapshotRegionLocator. This also adds a regression test with active, offline, and split entries that share start keys, and verifies region listing, start keys, and row lookup.Why are the changes needed?
Snapshot manifests can retain split parents.
SnapshotRegionLocatorpreviously exposed those entries alongside active daughter regions. This could makeHFileOutputFormat2configure more reducers than the number of unique keys written to the partition file, causing incremental backup to fail withWrong number of partitions in keyset.Filtering inactive entries in the locator keeps its region view consistent for all callers.
How was this patch tested?