Add support for Compression Dictionary Transport (RFC 9842) - #881
Add support for Compression Dictionary Transport (RFC 9842)#881arturobernalg wants to merge 1 commit into
Conversation
|
@arturobernalg This is a lot of new code. I will scan it for obvious programming errors or inefficiencies. I, however, cannot do a proper review as far as its conformance to the RFC is concerned. I will have to trust you know what you are doing. One question, though. Is there a reason this is an async only feature? |
|
ok2c
left a comment
There was a problem hiding this comment.
@arturobernalg I must admit i do not quite understand what is going on here, but some bits, especially header parsing ones do not good enough to me. I cannot make a call on this change-set
186ce58 to
a2ac48c
Compare
Implement dictionary negotiation, storage, matching, and dcb / dcz decoding
a2ac48c to
c6ac5f3
Compare
| } | ||
|
|
||
| // A caller-provided Accept-Encoding is honoured verbatim: the client neither rewrites it | ||
| // nor negotiates a dictionary on top of an explicit choice. |
| return null; | ||
| } | ||
|
|
||
| final Header[] headers = response.getHeaders(CompressionDictionaryHeaderSupport.USE_AS_DICTIONARY); |
There was a problem hiding this comment.
@arturobernalg This could be done much, much more efficiently. You are parsing and copying header values into a comma delimited list and then parsing it again. Consider using MessageSupport#parseHeaders or MessageSupport#parseHeadersStrict instead.
Implement dictionary negotiation, storage, matching, and dcb / dcz decoding