H2ws creation refactor: moved function to build binary, so that it's built only if websockets tests are run - #777
Open
PaulLodge wants to merge 1 commit into
Conversation
…built only if websockets tests are run
PaulLodge
changed the title
Collaborator
|
It is weird that this stuff is built during the test run rather than during build... have you looked at moving it out? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the h2ws build, so that it's built only if the websockets tests are run, so that if they aren't needed the ts won't keep trying to build them for each test that is run, thereby removing the need to to have all the dependencies even though the tests are never run.