fix(deps): Replace ${revision} with ${project.version} in artifacts path#352
Open
hingu-8103 wants to merge 1 commit into
Open
fix(deps): Replace ${revision} with ${project.version} in artifacts path#352hingu-8103 wants to merge 1 commit into
hingu-8103 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
The root POM uses
${revision}as the version property. However, two files reference${revision}directly in file path strings and<finalName>Whenmvn versions:set -DnewVersion=X.Y.Zis run, it updates<version>tags and occurences of${version}with newVersion but not in the strings and<finalName>— causing the copy tasks to look for JARs with the old version in their filename, breaking the build.Main Changes
computer/computer-dist/pom.xml:
${revision}with${project.version}in<copy>task file path attributes${project.version}ensures paths always match the actual artifact versioncomputer/computer-k8s-operator/pom.xml:
${revision}with${project.version}in<finalName>declarationWhy This Fix Works
${project.version}is dynamically resolved from the<version>tagmvn versions:setupdates the<version>tag,${project.version}automatically reflects the new versionVerifying these changes
Manual testing
Build with
mvn clean package -DskipTestssucceedsArtifact filenames match the actual project version
Can be tested with version update:
mvn versions:set -DnewVersion=1.8.0-test && mvn clean package -DskipTestsDoes this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need