Skip to content

chore(commons): remove redundant version property#3089

Merged
imbajin merged 2 commits into
apache:masterfrom
hingu-8103:feat#3088
Jul 12, 2026
Merged

chore(commons): remove redundant version property#3089
imbajin merged 2 commits into
apache:masterfrom
hingu-8103:feat#3088

Conversation

@hingu-8103

@hingu-8103 hingu-8103 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Purpose of the PR

The hugegraph-commons module is already versioned by ${revision}.
At the same time, the root POM defines a separate property hugegraph-commons.version that tracks the same value.

This creates a duplicated version source for the same module family.

Main Changes

  • Remove hugegraph-commons.version from root pom.xml
  • Replace ${hugegraph-commons.version} with ${project.version} in:
    • hugegraph-server/pom.xml
    • hugegraph-store/hg-store-rocksdb/pom.xml
    • hugegraph-pd/hg-pd-service/pom.xml
  • Keep version management consistent with existing project-level versioning

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • N/A

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 10, 2026

@vaijosh vaijosh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good observation @hingu-8103 . Thanks.
LGTM.

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.69%. Comparing base (2d63804) to head (9828811).

❗ There is a different number of reports uploaded between BASE (2d63804) and HEAD (9828811). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (2d63804) HEAD (9828811)
4 1
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3089      +/-   ##
============================================
- Coverage     37.96%   31.69%   -6.28%     
+ Complexity      519      498      -21     
============================================
  Files           805      816      +11     
  Lines         68404    69555    +1151     
  Branches       8993     9190     +197     
============================================
- Hits          25968    22043    -3925     
- Misses        39697    45110    +5413     
+ Partials       2739     2402     -337     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@imbajin imbajin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: yes. Summary:

  • The POM version replacement itself looks consistent, but one release/versioning instruction still references the removed hugegraph-commons.version property, and the PR has a visible codecov/project failure.
    • Evidence: hugegraph-commons/hugegraph-common/src/main/resources/version.properties still says hugegraph-commons.version in the pom file needs to be updated;
  • mvn -q -pl hugegraph-server,hugegraph-pd/hg-pd-service,hugegraph-store/hg-store-rocksdb -am validate -DskipTests passed locally; codecov/project is failing on the latest head.

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 11, 2026
@hingu-8103

Copy link
Copy Markdown
Contributor Author

Hi @imbajin,
I've addressed your concern and updated stale reference to hugegraph-commons.version in version.properties. Can we re-trigger the pipeline ?
Thanks.

@VGalaxies VGalaxies left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No actionable findings.

Verified git diff --check, repository-wide references, Maven effective-model resolution with -Drevision=9.9.9-review, and a clean git merge-tree.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 12, 2026
@imbajin imbajin changed the title fix(deps): remove redundant hugegraph-commons.version property chore(commons): remove redundant version property Jul 12, 2026
@imbajin imbajin merged commit 74e439f into apache:master Jul 12, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improve] Remove redundant hugegraph-commons.version property and unify commons dependency versioning

4 participants