Add ManageSnapshots.cherry_pick_snapshot

[1fanwang]

Rationale for this change

pyiceberg can stage a write on a branch and validate it there, but cannot publish it. Write and Audit work; Publish does not, so the last step happens outside Python — typically a Spark session calling system.cherrypick_snapshot.

This adds ManageSnapshots.cherry_pick_snapshot(), mirroring Java's CherryPickOperation:

• An append is replayed as a new snapshot on top of current, carrying its added data files and recording source-snapshot-id, plus published-wap-id when staged with a wap.id.
• Any other operation is fast-forwarded to when its parent is already current, and rejected otherwise with Java's message.
• Picking an existing ancestor is a no-op, and a wap.id may only be published once.

Not covered: dynamic overwrite (OVERWRITE with replace-partitions), which Java replays. It raises here rather than silently doing nothing. Worth a follow-up.

Prior art

#750 by @chinmay-bhat implemented this in 2024 and was closed by the stale bot with no review on merit; credit for getting there first is theirs. I rewrote rather than rebased, since ManageSnapshots has moved to pyiceberg/table/update/snapshot.py and the producer API changed underneath. This one is narrower: a single method, no publish_changes(wap_id) and no producer class, since fast_append() already does the work.

@chinmay-bhat — glad to hand this back if you would rather carry it.
Touches the same class as #3649 and the same test file as #3760; whichever merges second needs a trivial additive resolution, keeping both sides. Happy to rebase.

Are these changes tested?

Integration, against the REST catalog and Hive metastore from dev/docker-compose-integration.yml. It stages a branch write with a wap.id, advances main so the pick is a replay not a fast-forward, publishes, then checks the summary properties and that a second publish is refused.

Red, with pyiceberg/table/update/snapshot.py at upstream/main

$ git checkout upstream/main -- pyiceberg/table/update/snapshot.py
$ pytest tests/integration/test_snapshot_operations.py -m integration -k cherry_pick -q

E       AttributeError: 'ManageSnapshots' object has no attribute 'cherry_pick_snapshot'
tests/integration/test_snapshot_operations.py:366: AttributeError
FAILED ...::test_cherry_pick_snapshot_publishes_staged_write[session_catalog_hive]
FAILED ...::test_cherry_pick_snapshot_publishes_staged_write[session_catalog]
2 failed, 23 deselected

Green, with the change restored

$ pytest tests/integration/test_snapshot_operations.py -m integration -k cherry_pick -v

test_cherry_pick_snapshot_publishes_staged_write[session_catalog_hive] PASSED
test_cherry_pick_snapshot_publishes_staged_write[session_catalog] PASSED

The table goes [1, 9] -> [1, 2, 3, 9], the published snapshot carries
source-snapshot-id and published-wap-id=etl-001, and re-publishing raises
Duplicate request to cherry pick wap id that was published already: etl-001.

Ran the docs example verbatim too.
Unit, across the memory, sql, and sql_without_rowcount catalogs: replay onto a moved-on main, wap id recorded, duplicate publish rejected, append replayed when its parent is current, non-append fast-forwarded, ancestor no-op, and both rejection paths. Same red on unpatched source.

Full unit and integration suites pass; prek run -a clean.

Are there any user-facing changes?

ManageSnapshots.cherry_pick_snapshot(snapshot_id), plus a Write-Audit-Publish section in mkdocs/docs/api.md.

[Copilot]

Pull request overview

Adds a ManageSnapshots.cherry_pick_snapshot(snapshot_id) API to support Write-Audit-Publish (WAP) flows in PyIceberg by publishing a staged branch snapshot onto the current table state, mirroring Iceberg Java’s cherry-pick behavior.

Changes:

• Added ManageSnapshots.cherry_pick_snapshot() implementation, including WAP summary properties (source-snapshot-id, published-wap-id) and duplicate WAP publish protection.
• Added unit and integration tests covering replay vs fast-forward behavior, ancestor no-op, and error paths.
• Documented the WAP workflow in the public API docs.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
pyiceberg/table/update/snapshot.py	Implements ManageSnapshots.cherry_pick_snapshot() plus helpers for replaying appended files and validating WAP publish semantics.
tests/table/test_manage_snapshots.py	Adds unit tests for replay, fast-forward, ancestor no-op, unknown snapshot, non-append rejection, and WAP id duplication.
tests/integration/test_snapshot_operations.py	Adds an integration test validating WAP publish behavior against REST/Hive catalogs.
mkdocs/docs/api.md	Adds a Write-Audit-Publish usage section for cherry_pick_snapshot.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[1fanwang]

Good catch, fixed in 8abb5b5. That paragraph described an earlier draft where a pick was fast-forwarded whenever the table had not moved. The implementation follows Java: appends are always replayed, so the wap trail is recorded either way, and fast-forward is the fallback for a non-append whose parent is current.