feat: coalesce physically-stored _last_updated_sequence_number - #2985
Open
anoopj wants to merge 2 commits into
Open
feat: coalesce physically-stored _last_updated_sequence_number#2985anoopj wants to merge 2 commits into
anoopj wants to merge 2 commits into
Conversation
The prior change rejected files that physically carry a per-row _last_updated_sequence_number column. Read such columns instead and coalesce per the spec. i.e. use the per-row value where non-null, fall back to the file's data sequence number only where null. _row_id, whose fallback is positional, is a later PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Refs #2879
What changes are included in this PR?
The prior change rejected files that physically carry a per-row _last_updated_sequence_number column.
Read such columns instead and coalesce per the spec. i.e. use the per-row value where non-null, fall back to the file's data sequence number only where null.
_row_idis a later PR.Are these changes tested?
Added tests.