API: Clarify that a snapshot's operation describes committed changes - #17611
Open
dramaticlly wants to merge 1 commit into
Open
API: Clarify that a snapshot's operation describes committed changes#17611dramaticlly wants to merge 1 commit into
dramaticlly wants to merge 1 commit into
Conversation
The Javadoc for DataOperations mapped each value to the API that produces it, which implied that the operation reflects the intent of a write. Snapshot operations are determined by the changes that are committed instead, so a single API can produce different operations: RowDelta produces append when it only added data files and delete when it only added delete files. Each value now uses the description from the table spec so that the two definitions do not diverge.
Contributor
Author
|
FYI @rdblue @stevenzwu @RussellSpitzer if you want to take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the 08/11 morning meeting of Efficient column updates sync
, @rdblue raised a good point that we need more clarification on snapshot's operation type, as it describe the physical operation instead of write intend.
This PR updated the existing Javadoc to align with existing spec in https://iceberg.apache.org/spec/#snapshots, also remove the implementation details.