Data: Add Variant Support for file format tck - #17617
Open
Guosmilesmile wants to merge 2 commits into
Open
Conversation
Guosmilesmile
force-pushed
the
variant_file_format
branch
from
August 12, 2026 15:27
d4ea486 to
cdca93d
Compare
anoopj
approved these changes
Aug 12, 2026
| "Unsupported binary value class: " + value.getClass().getName()); | ||
| } | ||
|
|
||
| private static VariantVal toVariantVal(Variant variant) { |
Member
There was a problem hiding this comment.
optional: looks like this code is duplicate? Not a big deal since it's test code, optionally extract it to a shared helper?
Contributor
Author
There was a problem hiding this comment.
Yes, this is duplicated with a few Spark variant paths, but there isn’t an existing shared helper to reuse. The closest implementations are private helpers inside StructInternalRow / SparkParquetReaders, and RandomData has similar test-only logic.
Since this is test code and the helper is small, I think keeping it local is acceptable. I will extract a test-only helper and reuse it from both InternalRowConverter and RandomData.
uros-b
approved these changes
Aug 13, 2026
Member
|
LGTM, thank you @Guosmilesmile! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a support variant type for file format tck