Skip to content

Flink: Avoid per-record Set allocation in the dynamic sink forward check #17618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sqd wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −6
Open

Flink: Avoid per-record Set allocation in the dynamic sink forward check #17618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ....20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecordProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package org.apache.iceberg.flink.sink.dynamic;

import java.util.Map;
import java.util.Set;
import org.apache.flink.annotation.Internal;
import org.apache.flink.annotation.VisibleForTesting;
import org.apache.flink.api.common.functions.OpenContext;
Expand Down Expand Up @@ -233,8 +234,11 @@ public void close() {
*/
@VisibleForTesting
static boolean isForwardEligible(DynamicRecord data) {
Set<String> equalityFields = data.equalityFields();
// Checks identifier field ids directly rather than resolving equality field names, which would
// allocate per record.
return data.distributionMode() == null
&& DynamicSinkUtil.resolveEqualityFieldNames(data.equalityFields(), data.schema())
.isEmpty();
&& (equalityFields == null || equalityFields.isEmpty())
&& data.schema().identifierFieldIds().isEmpty();
Comment on lines -237 to +242

@mxm mxm Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny enough, data.schema().identifierFieldIds() also allocates a new Set, so I don't think this is much better. Maybe this is slightly faster because we avoid creating one more Set.

Could we add this optimization directly to resolveEqualityFieldNames?

}
}
8 changes: 6 additions & 2 deletions ...2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecordProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package org.apache.iceberg.flink.sink.dynamic;

import java.util.Map;
import java.util.Set;
import org.apache.flink.annotation.Internal;
import org.apache.flink.annotation.VisibleForTesting;
import org.apache.flink.api.common.functions.OpenContext;
Expand Down Expand Up @@ -233,8 +234,11 @@ public void close() {
*/
@VisibleForTesting
static boolean isForwardEligible(DynamicRecord data) {
Set<String> equalityFields = data.equalityFields();
// Checks identifier field ids directly rather than resolving equality field names, which would
// allocate per record.
return data.distributionMode() == null
&& DynamicSinkUtil.resolveEqualityFieldNames(data.equalityFields(), data.schema())
.isEmpty();
&& (equalityFields == null || equalityFields.isEmpty())
&& data.schema().identifierFieldIds().isEmpty();
}
}
8 changes: 6 additions & 2 deletions ...2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecordProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package org.apache.iceberg.flink.sink.dynamic;

import java.util.Map;
import java.util.Set;
import org.apache.flink.annotation.Internal;
import org.apache.flink.annotation.VisibleForTesting;
import org.apache.flink.api.common.functions.OpenContext;
Expand Down Expand Up @@ -233,8 +234,11 @@ public void close() {
*/
@VisibleForTesting
static boolean isForwardEligible(DynamicRecord data) {
Set<String> equalityFields = data.equalityFields();
// Checks identifier field ids directly rather than resolving equality field names, which would
// allocate per record.
return data.distributionMode() == null
&& DynamicSinkUtil.resolveEqualityFieldNames(data.equalityFields(), data.schema())
.isEmpty();
&& (equalityFields == null || equalityFields.isEmpty())
&& data.schema().identifierFieldIds().isEmpty();
}
}
Loading