Spark 4.1: Fix row lineage in vectorized ORC reads - #17635
Draft
joyhaldar wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Joy Haldar <joy.haldar@target.com>
Contributor
Author
|
cc: @pvary, @Guosmilesmile, please take a look when you have some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VectorizedSparkOrcReaders.StructConverter checked
idToConstantbefore any metadata column, so_row_idmatched the generic constant branch and every row receivedfirst_row_id. Stored per-row values were ignored and the position offset was never applied._last_updated_sequence_numberhad the same problem._row_idfor a file withfirst_row_id = 100. Rows 0 and 2 store explicit values (555, 557), rows 1 and 3 store null and should inherit100 + position.RowIdColumnVectorandLastUpdatedSeqColumnVector, mirroring RowIdReader and LastUpdatedSeqReader inOrcValueReaders.idToConstant, matching the row-based reader.StructConverterto look up stored_row_idand_last_updated_sequence_numbercolumns by field id.Row based
ORCgot lineage support in #15776 and #16534, but the vectorized reader was not added.Found while adding vectorized coverage to the format model TCK (#17610).