Fix retry bug in tree model query which ignore the time filter#18179
Open
JackieTien97 wants to merge 1 commit into
Open
Fix retry bug in tree model query which ignore the time filter#18179JackieTien97 wants to merge 1 commit into
JackieTien97 wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request improves the handling of the
WHEREcondition in query statements to better support retries during query analysis. The main changes ensure that the originalWHEREcondition is preserved and can be restored if needed, preventing issues caused by modifications during query processing.The most important changes are:
Enhancements for Query Retry Handling:
originalWhereConditionfield to theQueryStatementclass, along with getter and setter methods, to store the initialWHEREcondition for potential restoration. [1] [2]setWhereConditionBackToOriginal()method inQueryStatementto allow resetting theWHEREcondition to its original state.visitQuerymethod inAnalyzeVisitorto reset theWHEREcondition to its original value at the start of analysis, ensuring retries work as expected.Preservation of Original WHERE Condition:
analyzeGlobalTimeFiltermethod inAnalyzeVisitorto create and store a copy of the originalWHEREcondition before extracting the time predicate, and to set this copy in theQueryStatement. [1] [2]