MINOR: Refactor REST extension registration - #23150
Merged
Merged
Conversation
omkreddy
approved these changes
Aug 19, 2026
omkreddy
left a comment
omkreddy
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR. LGTM
mimaison
added a commit
that referenced
this pull request
Aug 21, 2026
Refactor the Connect REST extension registration logic Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
mimaison
added a commit
that referenced
this pull request
Aug 21, 2026
Refactor the Connect REST extension registration logic Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
mimaison
added a commit
that referenced
this pull request
Aug 21, 2026
Refactor the Connect REST extension registration logic Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
|
|
||
| HttpResponse response = executeRequest(server.advertisedUrl(), new HttpGet("/connectors")); | ||
| assertEquals(200, response.getStatusLine().getStatusCode()); | ||
| assertNotNull(response.getFirstHeader(extension.name)); |
Contributor
There was a problem hiding this comment.
@mimaison we should also check if admin api is accessible via advertisedUrl with rest extensions enabled
Suggested change
| assertNotNull(response.getFirstHeader(extension.name)); | |
| assertNotNull(response.getFirstHeader(extension.name)); | |
| HttpResponse adminResponse = executeRequest(server.advertisedUrl(), new HttpGet("/admin/loggers")); | |
| assertEquals(200, adminResponse.getStatusLine().getStatusCode()); | |
| assertNotNull(adminResponse.getFirstHeader(extension.name)); |
Member
Author
There was a problem hiding this comment.
Feel free to followup with a PR. Thanks
Contributor
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the Connect REST extension registration logic
Reviewers: Manikumar Reddy manikumar.reddy@gmail.com