Conversation
Extend the merge policy to allow different strategies to be used based when picking up the segments to merge. Force-pick 0-delete same-tier merges before TMP, but only when the index is mixed and segments sit above the floor. Append-only workloads bypass to the inner policy unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current merge policy was designed for documents, preferring merging of segments with deletes. For vectors, combining segments with no deletes is preferable since it preserves the eligibility for join-set merge path instead of doing a full rebuild.
Hence this PR which extends the merge policy to allow different strategies to be used based when picking up the segments to merge.