docs: reflect shipped release audit schema - #1034
Conversation
Generated-by: Codex (GPT-5)
potiuk
left a comment
There was a problem hiding this comment.
LGTM — the gap really is closed, and the replacement text is accurate. I checked each of the three claims against the tree:
skills/release-audit-report/audit-record-schema.mdexists and is the structured schema the old bullet said was missing.tools/skill-evals/evals/release-audit-report/exists as a full suite (step-0-preflight,step-1-gather-record,step-2-assemble-record).case-4-all-required-missingexists understep-2-assemble-record/fixtures/and is genuinely an incomplete-record fixture — every required field afterversion/planning_issue_urlisMISSING.case-2-missing-fieldscovers the partial case alongside it, so "validates incomplete records" is a fair description of the suite.
Rewriting the bullet in place rather than deleting it is also the right call for this file: the first entry under ## Known gaps already uses exactly this shape ("All ten skills have shipped — …"), so a resolved gap stays visible as a record instead of silently disappearing from the list.
Thanks for the first contribution to Apache Magpie — this is the kind of spec-drift fix that is easy to miss and annoying to discover later.
This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.More on how Apache Magpie handles maintainer review:
CONTRIBUTING.md § Opening a pull request.
Summary
Type of change
Test plan
uv run --project tools/spec-validator spec-validate tools/spec-loop/specs/prekhooks fortools/spec-loop/specs/release-management-lifecycle.md(including markdownlint, typos, lychee, placeholder checks, and spec validation)prek run --all-files— Windows path separators and materialized symlinks trigger unrelated repository-wide archive/workspace checks; the checks applicable to this one-file change pass.RFC-AI-0004 compliance
No runtime behaviour or state-changing workflow is changed.
Linked issues
Closes #936
Generative AI disclosure
This change was prepared with Codex (GPT-5). The commit records this with a
Generated-by:trailer and does not use an AICo-Authored-By:trailer.