Conversation
Generated-by: Codex (OpenAI)
Generated-by: Codex (OpenAI)
31681b8 to
93c7925
Compare
|
Status for maintainers: this PR is mergeable and has no review threads. The hosted Runtime Host step failed only in the unchanged |
Generated-by: OpenAI Codex
|
Synced current apache/main into head 74fdb22 on September 20, 2026. The merge was conflict-free and the effective PR diff remains limited to the two Computer Use runtime files. GitHub now reports MERGEABLE; fresh CI is running. Local full build was blocked by an unrelated current-main storage typing failure in read_usage, outside this PR diff. Please review the updated head. |
Review:推荐合并(Approve with nits)我按对抗式复核逐调用点比对了 复核确认的点
两个低危 nit(不阻塞合并)
关于 CI本地 |
me2seeks
left a comment
There was a problem hiding this comment.
推荐合并。逐调用点复核未发现高危正确性回归,重构行为等价;仅两个低危 nit(observingRecord! 远距离非空断言、缺真实 OS 输入验证),不阻塞。详见上方 review 评论。
Summary
Fixes #5474. After
element_sequencereturned a fresh observation, its next bound action was rejected asreobserve_required: the frame was registered but the session was not activated. Accept all six fresh-observation paths with a pre-capture lease check and synchronous frame/session activation. This also declines captures invalidated while in flight.A separate second commit shares the existing bound-action execution protocol between a single semantic action and each sequence step: recheck the action lease after presentation, preserve partial delivery as
outcome_unknown, and apply the same frame retirement/confirmation rules. Sequence still owns target lookup, progress, capture policy and response formatting; ordinary type/key is unchanged. Host/fake-backend timing checks do not establish real OS input delivery. Refs #4909; independent of open #5458.Verification
actual: reobserve_required; after the fix it passes. The presentation-stop and partial-delivery regressions also failed before the second commit and pass after it.npm run lint,npm run format:check,npm run build,npm run typecheck,npm run check:asf-headers, and both prescribedknipworkspace checks passed.npm testwas stopped at user request to avoid a large suite; before interruption, several concurrent runtime-host tests reported readiness/terminal timeouts. The first remotetestrun exposed a new-Turn observe lease regression in this PR; it failed the cross-layer contract, was fixed in the first commit, and the focused cross-layer test is green locally. The corrected head passed remote build, typecheck, and affected standard workspace tests. The later Runtime Host test step failed onruntime-resource-processwith a 60-second PTY control-close timeout (not in the changed code). This account lacks Actions rerun permission, so a maintainer needs to rerun that job. The full suite is not claimed green pending a privileged rerun of the Runtime Host step. No real Desktop/model/OS CU reproduction was run.AI use
Tool(s) and scope: Codex (OpenAI) authored the scoped runtime changes, regression tests, and this description; the contributor reviews and owns submission. Both commits carry
Generated-bytrailers.Checklist
Does this PR entail a change in behavior?