Skip to content

fix(ci): stabilize Storybook setup and transcript measurements - #5492

Open
liuxiaocs7 wants to merge 6 commits into
apache:mainfrom
liuxiaocs7:fix/storybook-tall-prompt-timeout
Open

fix(ci): stabilize Storybook setup and transcript measurements#5492
liuxiaocs7 wants to merge 6 commits into
apache:mainfrom
liuxiaocs7:fix/storybook-tall-prompt-timeout

Conversation

@liuxiaocs7

@liuxiaocs7 liuxiaocs7 commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Keep the existing Storybook and transcript geometry checks reliable on CI:

  • Prepare the tall prompt through native text insertion, preserving real Shift+Enter/submission and the full draft and scroll assertions within the existing 15-second deadline.
  • Wait for WorkHub's rendered navigation highlight on animation frames. Production navigation settles over 30 frames, which can outlast the assertion's one-second timer.
  • Increase the existing transcript measure-ahead margin from 2,000 to 4,000 px so mixed Markdown/code rows have more time to measure before they reach the reader. Keep all geometry thresholds and the bounded virtualized window assertions.

Remove the four temporary module-page comparison PNGs. No dependency patches, new tests, dependency updates, or README/LICENSE changes are included.

Fixes #5490

Verification

  • WorkHub at low frame rate: the original assertion failed twice, and the fix passed twice with the existing 15-second story deadline.
  • Geometry: all three production scenes passed three trials each. The original 2,000 px margin reproduced two cold-reader slips; the gate permits at most one. Warm-reader slips and height drift remained zero.
  • Upward traversal and its mounted-row limit passed six focused runs.
  • Full Storybook smoke passed: 380 stories, 412 theme renders.
  • All 508 UI tests, 2,719 Desktop tests, 92 ASF source checks, and 203 release contract checks passed.
  • Build, lint, formatting, typecheck (including stories), Desktop/UI Knip, clean dependency installation, and git diff --check passed.

GitHub CI passed on 18de372a6, including Desktop e2e, full Storybook smoke, and transcript geometry invariants.

AI use

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Codex reproduced the CI failures, made the scoped fixes, removed the requested images, and ran validation.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@liuxiaocs7
fix(ci): keep tall prompt Storybook setup within the render deadline
6950cd1 
Prepare prompt lines with native text insertion while preserving the real
Shift+Enter and submit paths. Assert the complete draft before measuring
scroll reversal, so an incomplete fixture cannot pass the geometry check.
Remove the four temporary module-page before/after PNGs from docs/images/pr.

Fixes apache#5490
Generated-by: Codex
@github-actions github-actions Bot added the effort/S Under 100 readable lines label Sep 18, 2026
@liuxiaocs7
fix(ui): retain consecutive virtualizer scroll corrections
78d37ab 
Record the DOM offset after each virtua height compensation so a second
ResizeObserver delivery cannot overwrite the previous correction before
the native scroll event. Keep absolute targets for browser clamping and
avoid flushSync for compensation updates inside React layout effects.

Cover both React entry points with ordered resize/scroll regressions and
retain the existing Chromium geometry gate without changing thresholds.

Refs apache#5490
Generated-by: Codex
@liuxiaocs7 liuxiaocs7 changed the title fix(ci): keep tall prompt Storybook setup within the render deadline fix(ci): stabilize tall prompt and transcript geometry checks Sep 18, 2026
@liuxiaocs7
docs: register the virtua patch license in source releases
72ee1fb 
Generated-by: Codex
@liuxiaocs7
revert(ui): remove the virtua dependency patch
7b20517 
Generated-by: Codex
@liuxiaocs7
fix(ci): settle WorkHub navigation and measure transcript rows earlier
18de372 
Wait for the rendered WorkHub highlight within the existing story deadline. Increase the existing measurement buffer to 4000px so mixed Markdown and code rows settle before reaching the reader.

Generated-by: Codex
@liuxiaocs7 liuxiaocs7 changed the title fix(ci): stabilize tall prompt and transcript geometry checks fix(ci): stabilize Storybook setup and transcript measurements Sep 18, 2026
@liuxiaocs7
Merge origin/main into fix/storybook-tall-prompt-timeout
08ae0b5 
Keep the upstream 4000px transcript measurement margin and its full rationale while retaining the Storybook prompt and WorkHub navigation fixes.

Generated-by: Codex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

effort/S Under 100 readable lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(ci): Storybook timing and transcript geometry failures on main

1 participant

@liuxiaocs7