Repository navigation
Conversation
…p on maven-it-helper junit-jupiter is a compile-scope dep of maven-it-helper but it is not needed at runtime by the plugin itself. Without the exclusion the IT local repo (which is isolated from central by a file:target/null mirror) cannot resolve junit-jupiter:5.8.0 when Maven loads the plugin during forked IT executions, causing: Could not find artifact org.junit.jupiter:junit-jupiter:jar:5.8.0 in central (file:target/null) The existing exclusions already strip maven-artifact, maven-verifier and junit (JUnit 4). This adds the matching JUnit 5 exclusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Maven loads
maven-it-plugin-project-interpolation:2.1-SNAPSHOTduring a forked IT execution, it needs to resolve the plugin's transitive dependencies. The plugin depends onmaven-it-helper, which declaresorg.junit.jupiter:junit-jupiter:5.8.0as a compile-scope dependency.The IT suite configures a
settings.xmlthat redirectscentraltofile:target/nullto enforce that all required artifacts come from the pre-populatedit-local-repo. Howeverjunit-jupiter:5.8.0is not installed intoit-local-repoby the outer build (it is downloaded as a build-time dep, not installed as a plugin runtime dep), so the forked Maven fails with:Fix
Add
org.junit.jupiter:junit-jupiterto the exclusion list on themaven-it-helperdependency in the plugin POM. The other test-only deps (maven-artifact,maven-verifier,junit:junit) were already excluded; this adds the matching JUnit 5 exclusion.The plugin code itself does not import or use
junit-jupiterat all — the dep onmaven-it-helperexists solely to exercise Maven's${project.version}interpolation in a plugin's dependency section.