Fix unresolved sticky class GC roots#9486
Open
wilx wants to merge 1 commit into
Open
Conversation
Assisted-by: OpenAI GPT-5 Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6357.
ROOT_STICKY_CLASSroots can refer to class object ids that are known fromLOAD_CLASSrecords but are not represented as resolvableInstances by this parser. In the attached issue dump, the failing sticky-class roots are known loaded classes, butGCRoot.getInstance()returnsnullfor them.LOAD_CLASSrecords describe classes loaded by the VM: they provide the class object id and class name metadata. They do not by themselves provide the full heap object data that NetBeans uses to construct anInstance; that comes from matching heap dump records such asCLASS_DUMP. When a sticky-class root points at aLOAD_CLASSid without a matching resolvable instance entry, the parser can identify the loaded class metadata but cannot return anInstance, so the result isnull.HprofGCRoots.getGCRoot(Long)assumed every parsed GC root has a non-nullInstancewhen building its instance lookup map. That made retained-size computation fail with aNullPointerExceptionbefore it could finish walking nearest GC roots.This change makes the GC-root lookup tolerate those unresolved roots. I also added a small synthetic HPROF regression that writes an unresolved sticky class root and verifies GC-root lookup handles it.
Validation performed:
getBiggestObjectsByRetainedSize(15)reproducer succeeds with the fixed profiler jar.HeapSegmentTest:OK (3 tests).testHeapDumpLoggolden-file assertions failed due to JVM system property output differences, unrelated to this change.Assisted-by: OpenAI GPT-5 Codex
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
LLMs, Commit messages and PR description:
git log) that all commits have a valid name and email address for you in the Author field.Assisted-by: MODEL_NAME MODEL_VERSIONline appended to the commit message.Assisted-byline from above)If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)