Updating Equinox to version 3.24.300

[jtulach]

• JGIT SSH commit signing / NetBinox removal / JNA as OSGI bundle #9483 removed platform/netbinox module
  • because it was using outdated patched Equinox version
• this PR priors the removal and updates Equinox to version 3.24.300
• the update is smooth and problematic
  • pros: updating to new version automatically uses the latest Equinox
  • cons: the Netbinox add-ons - e.g. connection to NetBeans caches aren't working
• check how well github action CI run 2 works
  • it compiles
  • tests are failing for now
• once @matthiasblaesing mentioned an idea of integrating just the plain Equinox - trying it in dd9f41c
  • CI execution scheduled - failures expected, but hopefully less than in the previous run

TODO

• fix the failing tests
• get the Netbinox caches working again

[jtulach]

Current (e.g. 3232159) set of failing tests:

[MartinBalin]

This is a must have fix as @matthiasblaesing #9483 completely broke VSNetBeans.

java.lang.IllegalStateException: No NetigsoFramework found, is org.netbeans.core.netigso module enabled?
	at org.netbeans.NetigsoHandle.getDefault(NetigsoHandle.java:63)
	at org.netbeans.NetigsoHandle.turnOn(NetigsoHandle.java:115)
	at org.netbeans.ModuleManager.doEnable(ModuleManager.java:1488)
	at org.netbeans.ModuleManager.enable(ModuleManager.java:1343)
	at org.netbeans.ModuleManager.enable(ModuleManager.java:1266)
	at org.netbeans.core.startup.ModuleList.installNew(ModuleList.java:313)
	at org.netbeans.core.startup.ModuleList.trigger(ModuleList.java:249)
	at org.netbeans.core.startup.ModuleSystem.restore(ModuleSystem.java:294)
	at org.netbeans.core.startup.Main.getModuleSystem(Main.java:174)
	at org.netbeans.core.startup.Main.getModuleSystem(Main.java:143)
	at org.netbeans.core.startup.Main.start(Main.java:305)
	at org.netbeans.core.startup.TopThreadGroup.run(TopThreadGroup.java:97)
	at java.base/java.lang.Thread.run(Thread.java:1474)
Cannot find org.netbeans.modules.java.lsp.server in the log!

I've built VSNetbeans against master after Matthias merged that and VSNetBeans does not start at all. Thanks' for fixing it Jaroslav. I'm now going to try out with your branch.

[neilcsmith-net]

@MartinBalin I believe that's because the plugin build excludes Felix. Please try with that included.

[matthiasblaesing]

@MartinBalin

1. it would be great if you could contact me/comment on the offending PR instead of a different PR from a different author
2. @neilcsmith-net already gave the right solution (NBCode excludes a long list of modules, Apache Felix being one of them)
3. I opened Update to NB master and fix missing OSGI runtime netbeans-vscode#35 which at least lets NBCode start again

Of course adding netbinox again would have "fixed" it, as NetBinox is not excluded from distribution...

Discussion about that should either be moved to the PR for the Fix or to the PR that introduced the "regression".

[matthiasblaesing]

Given the list of unfinished tasks, I assume the review request was triggered accidentally?

[JaroslavTulach]

1. it would be great if you could contact me/comment on the offending PR instead of a different PR from a different author

• Exactly, +1
• @MartinBalin the real issue to complain at is JGIT SSH commit signing / NetBinox removal / JNA as OSGI bundle #9483
• this is my PR which might fix the problem, but this PR isn't the core of your problems

[MartinBalin]

Hi, I did not mean to offend anyone. I will look and continue in Matthias PR. thank you

[jtulach]

• the release of NetBeans 32 will use Felix as the OSGi container
  • it seems to work OK ...
  • ... as there are no Mylyn OSGi bundles in NetBeans anymore - e.g. ...
  • ... we are OK with standard OSGi support, we don't need Equinox extensions
• NetBeans and Felix are Apache projects
  • make sense to support each other ...
  • ... especially when there are no other benefits of using Equinox anymore
  • possibly we can speed the Felix up using the NetBeans caches the same way we did with Netbinox
• having two OSGi containers in NetBeans was always a bit confusing and only justifiable by consumer needs
• on an on, I am closing this issue and giving up on re-integrating 2nd OSGi container into NetBeans Platform