Skip to content

Fix NPE during form designer component rename #9674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbien merged 1 commit into from
Oct 13, 2026
Merged

Fix NPE during form designer component rename #9674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions ...oring.java/src/org/netbeans/modules/refactoring/java/plugins/RenameRefactoringPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
*/
public class RenameRefactoringPlugin extends JavaRefactoringPlugin {

private Set<ElementHandle<ExecutableElement>> allMethods = new HashSet<ElementHandle<ExecutableElement>>();
private Set<ElementHandle<ExecutableElement>> allMethods = new HashSet<>();
private Set<TreePathHandle> recordLinkedDeclarations = new HashSet<>();
private boolean doCheckName = true;
private Integer overriddenByMethodsCount = null;
Expand Down Expand Up @@ -92,9 +92,7 @@ public void run(CompilationController co) throws Exception {
}
}
}, false);
} catch (IllegalArgumentException ex) {
ex.printStackTrace();
} catch (IOException ex) {
} catch (IllegalArgumentException | IOException ex) {
ex.printStackTrace();
}
}
Expand Down Expand Up @@ -610,17 +608,15 @@ public Problem prepare(RefactoringElementsBag elements) {
Set<FileObject> a = getRelevantFiles();
fireProgressListenerStart(AbstractRefactoring.PREPARE, a.size());
TransformTask transform = new TransformTask(new RenameTransformer(treePathHandle, docTreePathHandle, refactoring, allMethods, recordLinkedDeclarations, refactoring.isSearchInComments()), treePathHandle != null && treePathHandle.getKind() == Tree.Kind.LABELED_STATEMENT ? null : treePathHandle);
Problem problem = createAndAddElements(a, transform, elements, null);
Problem problem = createAndAddElements(a, transform, elements, refactoring);
fireProgressListenerStop();
return problem;
}

private Problem willOverride(ExecutableElement method, String name, Problem problem, CompilationInfo info) {
boolean isStatic = method.getModifiers().contains(Modifier.STATIC);
TypeElement jc = (TypeElement) method.getEnclosingElement();
LinkedList supertypes = new LinkedList();

ElementUtilities ut = info.getElementUtilities();
Elements elements = info.getElements();
ExecutableElement m = null;

Expand Down
Loading