Repository navigation
Conversation
Legacy Fix impls which were not EnhancedFixes yet were sorted with the same key. This made made their list position unstable. Their text is now appended to the key which should produce better results. bonus: While testing I noticed that some fixes didn't get deduplicated due to the fact that they didn't implement proper equals/hashCode. Those are now records.
mbien
added
Java
Member
|
Looks good. Thanks! I took a brief look through the issue yesterday, but was assuming use of unordered Set somewhere rather than this.
|
Member
Author
|
the record changes are also fixing an issue since those objects didn't have proper equals/hashcode |
Member
Author
|
tbh it would have been more elegant to move |
Member
Sorry, completely missed that - I'll try reading everything you've written next time! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy
Fiximpls which were notEnhancedFixesyet were sorted with the same key. This made their list position unstable. Their text is now appended to the key which should produce better results.bonus:
While testing I noticed that some fixes didn't get deduplicated due to the fact that they didn't implement proper equals/hashCode. Those are now records.
fixes #9658