Skip to content

MINIFICPP-2876 Manifest bundles invalid groupname - #2227

Closed
martinzink wants to merge 10 commits into
mainfrom
MINIFICPP-2876
Closed

MINIFICPP-2876 Manifest bundles invalid groupname#2227
martinzink wants to merge 10 commits into
mainfrom
MINIFICPP-2876

Conversation

@martinzink

Copy link
Copy Markdown
Member

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@martinzink martinzink added priority Review these first bug-fix c-api labels Aug 4, 2026
@martinzink
martinzink requested a lite review from Copilot August 4, 2026 15:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Comment thread extensions/standard-processors/tests/unit/ManifestTestHelper.h Outdated
@szaszm

szaszm commented Aug 4, 2026

Copy link
Copy Markdown
Member

I think copilot got overwhelmed by the 13k diff from the manifest change

Comment thread core-framework/include/core/Resource.h
Comment thread minifi-api/include/minifi-cpp/agent/agent_docs.h
Comment thread extensions/python/PythonCreator.h Outdated
@fgerlits fgerlits closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants