tests: fix race in GdbController gcore tests - #17
Open
raiden00pl wants to merge 1 commit into
Open
Conversation
The gcore tests wrote the "Saved corefile" and GCORE_MARKER reply lines into the pipe before calling generate_coredump(). If the reader thread consumed those lines before generate_coredump() reset _gcore_done and _last_corefile, the reset discarded them and the wait timed out, returning None (seen as a flaky CI failure on the Python 3.14 job). Feed the reply via a proc.stdin.write side effect triggered by the GCORE_MARKER echo command instead, so it arrives only after the controller has issued the gcore command -- mirroring real gdb and making the ordering deterministic. Signed-off-by: raiden00pl <raiden00@railab.me> Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gcore tests wrote the "Saved corefile" and GCORE_MARKER reply lines into the pipe before calling generate_coredump(). If the reader thread consumed those lines before generate_coredump() reset _gcore_done and _last_corefile, the reset discarded them and the wait timed out, returning None (seen as a flaky CI failure on the Python 3.14 job).
Feed the reply via a proc.stdin.write side effect triggered by the GCORE_MARKER echo command instead, so it arrives only after the controller has issued the gcore command -- mirroring real gdb and making the ordering deterministic.