tools/nxstyle: check alignment of statements without a leading keyword - #19934
Merged
Conversation
raiden00pl
force-pushed
the
nxstyle_fixes_pr4
branch
from
August 23, 2026 08:04
35d7e51 to
6b04b91
Compare
Only lines beginning with a C keyword were checked, so an assignment or a call could sit at any column. Signed-off-by: raiden00pl <raiden00@railab.me> Assisted-by: Claude Code
raiden00pl
force-pushed
the
nxstyle_fixes_pr4
branch
from
August 24, 2026 12:13
6b04b91 to
a87d5cd
Compare
raiden00pl
marked this pull request as ready for review
August 24, 2026 12:13
raiden00pl
requested review from
davids5,
jerpelea and
johannes-nivus
as code owners
August 24, 2026 12:13
xiaoxiang781216
approved these changes
Aug 24, 2026
cederom
approved these changes
Aug 24, 2026
cederom
left a comment
Contributor
There was a problem hiding this comment.
Thank you @raiden00pl :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Only lines beginning with a C keyword were checked, so an assignment or a call could sit at any column.
Impact
nuttx coding standard compatibility
Testing
detect wrong alignment like below: