HDDS-15932. Remove usage of internal AWS S3 SDK API in S3KeyGenerator#10835
Merged
Conversation
echonesis
marked this pull request as ready for review
July 22, 2026 05:01
chihsuan
approved these changes
Jul 22, 2026
chihsuan
left a comment
chihsuan
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch. LGTM.
adoroszlai
reviewed
Jul 25, 2026
adoroszlai
approved these changes
Jul 25, 2026
Contributor
|
Thanks @echonesis for the patch. |
Contributor
Author
|
Thanks @adoroszlai for the review and merge, @chihsuan for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removes the compile-time dependency on the internal AWS S3 SDK class
SkipMd5CheckStrategyfromS3KeyGenerator.Instead of importing the internal constant
DISABLE_PUT_OBJECT_MD5_VALIDATION_PROPERTY, the generator now sets the equivalent system property directly:com.amazonaws.services.s3.disablePutObjectMD5ValidationThis preserves the existing behavior while avoiding the use of an API from the AWS SDK's internal package.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15932
How was this patch tested?
GitHub Actions CI: https://github.com/echonesis/ozone/actions/runs/29884841702