Skip to content

HDDS-15933. Remove usage of jersey internal ContainerRequest - #10839

Merged
adoroszlai merged 1 commit into
apache:masterfrom
echonesis:HDDS-15933
Jul 25, 2026
Merged

HDDS-15933. Remove usage of jersey internal ContainerRequest#10839
adoroszlai merged 1 commit into
apache:masterfrom
echonesis:HDDS-15933

Conversation

@echonesis

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

TestVirtualHostStyleFilter used Jersey's internal ContainerRequest implementation to construct requests for testing. This introduced an unnecessary dependency on Jersey implementation details.

This PR:

  • replaces ContainerRequest with mocked standard JAX-RS ContainerRequestContext and UriInfo interfaces;
  • verifies request URI updates through ContainerRequestContext#setRequestUri;
  • preserves query parameter coverage without relying on query parameter ordering; and
  • removes the unused direct jersey-common dependency from ozone-s3gateway. The dependency remains available transitively through jersey-server.

Generated-by: Codex (GPT-5)

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-15933

How was this patch tested?

Local Test

mvn -pl :ozone-s3gateway test \
    -Dtest=TestVirtualHostStyleFilter \
    -DskipShade -DskipRecon -DskipDocs

GitHub Actions CI: https://github.com/echonesis/ozone/actions/runs/29900380211

@chihsuan chihsuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. LGTM.

@chungen0126 chungen0126 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@chungen0126
chungen0126 requested a review from adoroszlai July 25, 2026 08:23
@adoroszlai
adoroszlai merged commit 1b8f5f8 into apache:master Jul 25, 2026
45 checks passed
@adoroszlai

Copy link
Copy Markdown
Contributor

Thanks @echonesis for the patch, @chihsuan, @chungen0126 for the review.

@echonesis

Copy link
Copy Markdown
Contributor Author

Thanks @chihsuan, @chungen0126 for the review, @adoroszlai for the merge.

@echonesis
echonesis deleted the HDDS-15933 branch July 27, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants