HDDS-15982. Fix UnsupportedOperationException and add idempotency to RangerClientMultiTenantAccessController#10872
Open
MahmoudHassanen99 wants to merge 4 commits into
Open
Conversation
…RangerClientMultiTenantAccessController Co-authored-by: sallmayasser <sallmayasser512@gmail.com>
adoroszlai
reviewed
Jul 26, 2026
adoroszlai
left a comment
adoroszlai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @MahmoudHassanen99 for the patch. Please enable workflows in your fork.
ayushtkn
reviewed
Jul 26, 2026
Author
|
Thanks @adoroszlai and @ayushtkn for the review I have pushed a new commit addressing all the feedback (cleaned up Javadoc/license, removed internal tags, and kept single-line logging). Ready for another look |
Co-authored-by: Amr ElBoridy <amrelboridy7@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
UnsupportedOperationExceptionwhen initializing policy items/accesses inRangerClientMultiTenantAccessControllerby using explicit mutableArrayListinstances.createRoleandcreatePolicyoperations (gracefully catches HTTP 400 duplicate errors and fetches the existing resource).deleteRoleanddeletePolicyoperations (gracefully catches HTTP 404 missing errors).What is the link to the Apache JIRA issue?
https://issues.apache.org/jira/browse/HDDS-15982
How was this patch tested?
Verified via code inspection and integration flow testing for multi-tenant Ranger client access management.