Skip to content

[Bug] Flaky blob fallback read-limit test on release-0.4 #548

Closed

Description

@lucasfang

Problem

BlobFallbackBatchReaderTest.TestRejectsBatchExceedingReadLimit intermittently fails on release-0.4 at commit b6c035026acdb4ec8c5a252854963a541417b61e (v0.4.0-rc4).

Observed in the gcc-release-aarch64 CI job:

'reader->NextBatch()' did not fail

Cause and expected behavior

The test needs its oversized mock reader to return two rows for a one-row read/skip request. However, MockFileBatchReader randomizes the batch size by default in the range [1, 1024]. When it chooses 1, the returned batch satisfies the limit, so the expected error correctly does not occur. Both the covered and uncovered cases can hit this.

Disable batch-size randomization for this mock so both paths always exercise rejection of an oversized batch. Production reader behavior and the existing assertions should stay unchanged.

Reproduction

Repeat the test on the affected revision:

./build/debug/paimon-common-test \
  --gtest_filter=BlobFallbackBatchReaderTest.TestRejectsBatchExceedingReadLimit \
  --gtest_repeat=3000

The previous local investigation reproduced 6 failures in 3000 iterations on x86_64 Debug; this is not specific to aarch64.

Release backport

The exact one-line fix is already on main in #534, commit 7515bf6837af93e12e8ce610779146533966b747. This issue tracks backporting only that test fix to release-0.4, without the query-auth feature or other changes from #534.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions