Skip to content

chore: clarify contribution guidelines and squash commit defaults - #528

Merged
lxy-9602 merged 3 commits into
apache:mainfrom
zjw1111:codex/contribution-metadata-checks
Nov 10, 2026
Merged

lxy-9602 merged 3 commits into
apache:mainfrom
zjw1111:codex/contribution-metadata-checks

Conversation

@zjw1111

@zjw1111 zjw1111 commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Purpose

Default squash commits to the PR title with an empty commit body. Clarify contribution requirements for Issue templates and Conventional Commits titles, and explain what belongs in the PR template's Tests section.

Tests

No test changes are needed because this PR only updates repository merge settings and contribution documentation.

API and Format

No public C++ API, storage format, or protocol changes.

Documentation

Document the 11 lowercase Conventional Commits types, optional scopes and breaking-change markers, and require Issues to use the appropriate template and complete all required fields. Clarify that the PR template's Tests section describes added or updated tests and their coverage.

Generative AI tooling

Generated-by: OpenAI Codex (GPT-6)

@SteNicholas SteNicholas left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zjw1111, I left the below three comments for this pull request. PTAL.

Comment thread ci/scripts/check_pr_metadata.py Resolved
Comment thread ci/scripts/check_pr_metadata.py Resolved
Comment thread ci/scripts/check_pr_metadata.py Resolved
@zjw1111

zjw1111 commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator Author

The PR checks will need further adjustments, so I am marking this PR as a draft for now.

@zjw1111
zjw1111 marked this pull request as draft November 9, 2026 11:02
@zjw1111 zjw1111 changed the title ci: validate issue and PR metadata chore: clarify contribution guidelines and squash commit defaults Nov 10, 2026
@zjw1111
zjw1111 marked this pull request as ready for review November 10, 2026 02:40

@lxy-9602 lxy-9602 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zjw1111
zjw1111 requested a review from SteNicholas November 10, 2026 06:13

@SteNicholas SteNicholas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lxy-9602
lxy-9602 merged commit a99f60d into apache:main Nov 10, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants