Repository navigation
feat: support weighted data paths and round-robin global index paths - #545
Merged
Merged
Conversation
lszskye
force-pushed
the
optimize_external_path
branch
from
November 10, 2026 11:35
3c972d8 to
18afb70
Compare
lxy-9602
reviewed
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #543
Support weighted placement of data files and distribute index files and
checkpoints across multiple external directories.
data-file.external-paths.weightsand theweightedstrategy.Weights apply only to this strategy; empty weights fall back to round robin.
global-index.external-path, withindependent round-robin selection for index files and checkpoints.
selecting the largest checkpoint ID. Continue ID allocation from that
maximum and clean up checkpoints across all configured roots.
metadata, and cleanup, without a filename-to-path cache.
when
index-file-in-data-file-dir=false.Tests
strategies, and parsing multiple global index roots.
continued task cleanup after a deletion failure, and deletion error
propagation.
and the revised factory interfaces.
API and Format
Options::DATA_FILE_EXTERNAL_PATHS_WEIGHTS.GlobalIndexFileWriter::NewFileName()withNewPath()and remove itsToPath()method. Callers must retain thereturned full path and pass it to
NewOutputStream()andGetFileSize().existing metadata field, and checkpoint filenames retain their format.
Generative AI tooling
Generated-by: OpenAI Codex (GPT-6)