Repository navigation
test: stabilize blob fallback read-limit check on release-0.4 - #549
Merged
SteNicholas merged 1 commit intoNov 11, 2026
Merged
SteNicholas merged 1 commit into
SteNicholas merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: closes #548
Backport the one-line flaky-test fix from #534 (
7515bf6837af93e12e8ce610779146533966b747) torelease-0.4.TestRejectsBatchExceedingReadLimitneeds the mock to return two rows for a one-row read/skip request. The mock randomizes batch sizes by default, occasionally returning only one row and making the expected rejection disappear. Disable randomization for this oversized mock so both the covered and uncovered paths always exercise the existing assertion.Scope: one line in one test file. No production changes or other changes from #534.
Tests
The existing
BlobFallbackBatchReaderTest.TestRejectsBatchExceedingReadLimitstill covers both read and skip requests and verifies that the request context is cleared after rejection.Local validation on x86_64 Debug with ASAN:
BlobFallbackBatchReaderTest.*: 17 tests passed.BlobFallbackBatchReaderTest.TestRejectsBatchExceedingReadLimit --gtest_repeat=3000: all 3000 iterations passed.pre-commit run --files src/paimon/common/reader/blob_fallback_batch_reader_test.cppandgit diff --check: passed.The original test previously failed 6 times in 3000 local iterations. The failing aarch64 Release CI job and a fresh full release-branch build were not rerun locally.
API and Format
No public API, storage format or protocol changes.
Documentation
No documentation changes are needed for this test-only fix.
Generative AI tooling
Generated-by: OpenAI Codex (GPT-6)