Repository navigation
perf(global-index): materialize bitmap results eagerly and batch unions - #552
Merged
Merged
Conversation
lszskye
reviewed
Nov 12, 2026
lszskye
reviewed
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #551 .
Global index bitmap results retain suppliers and their captured objects until first access. Merging multiple results through repeated pairwise OR operations also repeatedly copies growing intermediate bitmaps.
This change:
UnionResultshelper that usesFastUnionfor bitmap results across sorted-file readers, union readers, and OR predicate evaluation. Other result types retain their virtual Or behavior.&=, avoiding an extra result copy.Existing handling of unavailable index results, predicate field tracking, and scored-result semantics is preserved.
Tests
Added or updated coverage for:
API and Format
The public
BitmapGlobalIndexResultconstructor now accepts aRoaringBitmap64. Supplier-based callers useBitmapGlobalIndexResult::Create(), which executes the supplier immediately and returns any error.No storage format or protocol changes.
Documentation
Updated public API comments to describe result creation and bitmap access.
Generative AI tooling
Generated-by: OpenAI Codex (GPT-6)