Repository navigation
feat: support custom compaction for bucketed append tables - #572
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #571
The existing Compact API selects input files through built-in strategies. This change allows callers to compact an explicit file set using their own selection policy.
FileStoreWrite::CompactFiles.PrepareCommit.Custom compaction requires
bucket-append-ordered=false,write-only=false, and a dedicated writer with the full schema. Real-time mode and data evolution are unsupported. Callers must serialize deletion-vector updates and compaction for the same partition-bucket until commit or discard.Tests
Unit tests cover input validation, writer restoration, asynchronous task handling, and repeated file selection.
Integration tests cover non-contiguous inputs with and without deletion vectors, a fully deleted input file, commit-message serialization, and post-commit reads.
API and Format
Adds the public
FileStoreWrite::CompactFilesAPI.No storage format or commit-message protocol changes.
Documentation
Documents custom compaction and bucket-append-ordered behavior in the user guide.
Generative AI tooling
Generated-by: OpenAI Codex (GPT-6)