Repository navigation
feat(file-index): track result exactness and support global top-k - #573
Merged
Merged
Conversation
lszskye
force-pushed
the
multi_file_index_optimize
branch
from
November 16, 2026 13:26
a02b111 to
f7a4f54
Compare
lxy-9602
reviewed
Nov 17, 2026
lszskye
force-pushed
the
multi_file_index_optimize
branch
from
November 19, 2026 08:17
f7a4f54 to
9be4b86
Compare
Preserve optional root search field names and reject missing names when a root search is present. Remove nullable normalization from TopKBatchReader and disable three affected realtime integration tests with TODOs pending a reader schema fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #452
Scalar index evaluation previously rechecked indexed rows without distinguishing exact results from potentially incomplete results. Root search limits were also applied per file, so reading multiple files could return more than the requested TopK.
This change:
Tests
Coverage includes:
API and Format
Documentation
Updates the file-index guide and public API comments for result exactness.
Generative AI tooling
Generated-by: OpenAI Codex