Repository navigation
fix: reject empty IN and NOT IN predicates - #579
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The default
FileIndexReader::VisitIn()andVisitNotIn()implementationsreturn success with a null result when given an empty literal list. Bloom
index evaluation inherits these implementations and can dereference the
null result.
Reject empty
INandNOT INlists withStatus::Invalidduring predicatevalidation and when file index readers are called directly. Apply consistent
checks across reader implementations and correct the bitmap
NOT INerrormessage.
Tests
INandNOT INlists, includingpredicates nested within
ANDandOR.IS NULL/IS NOT NULLremain valid.empty index readers.
as well as both bitmap index format versions.
API and Format
No API signature, storage format, or protocol changes.
Empty
INandNOT INlists are now consistently rejected during validationand direct file index evaluation.
Documentation
Update predicate builder comments to describe empty-list rejection and
document that successful
FileIndexReadervisits return non-null results.Generative AI tooling
Generated-by: OpenAI Codex (GPT-6)