Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #581
Add
FileIndexWrite::PrepareCommitto attach caller-provided serialized index payloads to existing data files without rewriting the data.The API resolves target files from a specified snapshot, merges supplied field/type pairs with existing indexes, writes one external index container per data file, and returns commit messages grouped by partition and bucket.
Backfill commits must be serialized with compaction/overwrite per partition and bucket.
Tests
Added coverage for:
API and Format
Add the public
FileIndexInput,DataFileIndexInput, andFileIndexWriteAPIs.Inputs use original data-file field names and physical row positions, including DV-deleted rows. Null filesystem, memory pool, and executor arguments select internal defaults.
Reuse existing index container and commit message formats; no storage format or protocol changes.
Documentation
Add API references and a user-guide example covering payload inputs, commit usage, and concurrency assumptions.
Generative AI tooling
Generated-by: OpenAI Codex (GPT-6)