Repository navigation
fix(core): read data-evolution files of an incremental window that are not column slices as stored #1422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jackylee-ch
wants to merge
3
commits into
apache:main
Choose a base branch
from
jackylee-ch:fix/data-evolution-column-slices
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(core): read data-evolution files of an incremental window that are not column slices as stored #1422
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
7116012
fix(core): read data-evolution files of an incremental window that ar…
jackylee-ch 6e45635
[core] Add the license header to data_evolution_window_test.rs
jackylee-ch 373f19b
fix(core): preserve physical events during incremental scan pruning
jackylee-ch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Apply physical-event semantics before scan pruning
Selecting raw events only here is too late: TableScan has already applied merged-row statistics and read-field pruning. On this PR's own two inserts (values 1..4) → compaction → value-only update to 50 fixture, the full timestamp window returns 8 physical events. With
with_projection(&["id"]), its scan drops the update-only file and returns 4 rows; withwith_filter(value = 1), latest-provider stats (min=max=50) drop the entire group and return zero instead of the original(1,1)event. Both are public-API reproductions on this exact head. Reading the original unfiltered/full-width plan through the same projected or filtered reader returns 8 or 1 respectively.Please classify these physical-event groups before planner statistics/field pruning and use event-safe per-file pruning (preserving events whose projected fields are absent as NULL), or conservatively disable the merged-group optimizations for them. Add projection and predicate regressions alongside the two existing unfiltered window tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 373f19b: incremental non-column-slice groups now bypass merged statistics and projection pruning before the raw read, with projection and predicate regressions verified on the old and new heads.