Repository navigation
[Improvement] Avoid an unnecessary S3 PUT when opening a data file #1465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ZENOTME
wants to merge
1
commit into
apache:main
Choose a base branch
from
ZENOTME:codex/skip-s3-directory-marker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we skip
mkdirs()for S3 inFileIOand keep it for backends that need it? I tested aFileIOProviderbacked by OpenDAL WebDAV with automatic parent creation disabled. Both append and primary-key writes to a newbucket-0failed with HTTP 409 duringprepare_commit(). The same writes passed after explicitly creating the bucket directory.Could we also add a regression test that checks both S3 write paths produce a Parquet file without sending a directory marker PUT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that each operator handles parent directories as needed. E.g. FsWriter::create() calls ensure_write_abs_path(), which creates missing parent directories. The WebDAV writer does the same by default in WebdavWriter::write_once().
Is there a use case for disabling automatic directory creation when the WebDAV server requires the parent to exist, or is the concern mainly backward compatibility with providers that rely on Paimon to create it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly backward compatibility. I don’t have a concrete use case for that WebDAV setup. I used it to reproduce what happens when a custom provider relies on Paimon to create the bucket directory.
I’m fine with leaving parent directory creation to the operator and documenting that in FileIOProvider. @JingsongLi does that match what you’d expect from FileIOProvider?